forks/apenwarr-redo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
apenwarr-redo/t/deps/dirtest/test.do

16 lines
309 B
Text
Raw Normal View History

Remove special case for "dirname" -> "dirname/all" It actually decreases readability of the .do files - by not making it explicit when you're going into a subdir. Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all? We could resolve the ambiguity if we wanted, but that adds more code, while taking out this special case makes *less* code and improves readability. I think it's the right way to go.
2010-11-24 02:48:27 -08:00
rm -f log dir1/log dir1/stinky
touch t1.do
Rename flush-cache.py to flush-cache, and rearrange the code a bit. It was working fine, but the style wasn't exactly the way I like it, because I'm unnecessarily picky. :) Also, removed the file extension since we should probably learn from the fact that it's already been rewritten once from one language to another. Who knows, maybe it will be again someday.
2011-02-23 01:24:48 -08:00
../../flush-cache
Remove special case for "dirname" -> "dirname/all" It actually decreases readability of the .do files - by not making it explicit when you're going into a subdir. Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all? We could resolve the ambiguity if we wanted, but that adds more code, while taking out this special case makes *less* code and improves readability. I think it's the right way to go.
2010-11-24 02:48:27 -08:00
redo t1
touch t1.do
Rename flush-cache.py to flush-cache, and rearrange the code a bit. It was working fine, but the style wasn't exactly the way I like it, because I'm unnecessarily picky. :) Also, removed the file extension since we should probably learn from the fact that it's already been rewritten once from one language to another. Who knows, maybe it will be again someday.
2011-02-23 01:24:48 -08:00
../../flush-cache
Remove special case for "dirname" -> "dirname/all" It actually decreases readability of the .do files - by not making it explicit when you're going into a subdir. Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all? We could resolve the ambiguity if we wanted, but that adds more code, while taking out this special case makes *less* code and improves readability. I think it's the right way to go.
2010-11-24 02:48:27 -08:00
redo t1
Rename flush-cache.py to flush-cache, and rearrange the code a bit. It was working fine, but the style wasn't exactly the way I like it, because I'm unnecessarily picky. :) Also, removed the file extension since we should probably learn from the fact that it's already been rewritten once from one language to another. Who knows, maybe it will be again someday.
2011-02-23 01:24:48 -08:00
../../flush-cache
Remove special case for "dirname" -> "dirname/all" It actually decreases readability of the .do files - by not making it explicit when you're going into a subdir. Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all? We could resolve the ambiguity if we wanted, but that adds more code, while taking out this special case makes *less* code and improves readability. I think it's the right way to go.
2010-11-24 02:48:27 -08:00
redo-ifchange t1
C1="$(wc -l <dir1/log)"
C2="$(wc -l <log)"
Disable the tests that don't work with minimal/do. ...only when running under minimal/do, of course. The tests in question mostly fail because they're testing particular dependency-related behaviour, and minimal/do doesn't support dependencies, so naturally it doesn't work.
2010-12-11 20:54:46 -08:00
. ../../skip-if-minimal-do.sh
Fix tests on MacOS. This comes down to the lack of a 'seq' command (what?!) and the fact that BSD "wc -l" returns extra whitespace, while the GNU version doesn't. We should be using numeric comparisons instead of string comparisons, and then it's ok.
2010-12-12 05:38:30 -08:00
if [ "$C1" -ne 1 -o "$C2" -ne 2 ]; then
Remove special case for "dirname" -> "dirname/all" It actually decreases readability of the .do files - by not making it explicit when you're going into a subdir. Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all? We could resolve the ambiguity if we wanted, but that adds more code, while taking out this special case makes *less* code and improves readability. I think it's the right way to go.
2010-11-24 02:48:27 -08:00
echo "failed: t1>t1, c1=$C1, c2=$C2" >&2
exit 55
fi
Reference in a new issue Copy permalink