From 0979a6e666703da0fcbf0ced1b90f0a53c38c263 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Mon, 6 Dec 2010 03:12:02 -0800 Subject: [PATCH] t/passfailtest.do: just return exit codes, don't print messages. The exit code numbers are useful enough, and the messages are the sort of thing that might turn into lies eventually. --- t/passfailtest.do | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/t/passfailtest.do b/t/passfailtest.do index 5eb77d0..52bb0e9 100644 --- a/t/passfailtest.do +++ b/t/passfailtest.do @@ -1,28 +1,13 @@ rm -f pleasefail redo passfail -if [ ! -e passfail ]; then - echo "passfail should exist" >&2 - exit 42 -fi +[ -e passfail ] || exit 42 PF1=$(cat passfail) touch pleasefail -if redo passfail 2>/dev/null; then - echo "redo passfail should have failed" >&2 - exit 42 -fi -if [ ! -e passfail ]; then - echo "passfail should STILL exist" >&2 - exit 42 -fi +redo passfail 2>/dev/null && exit 43 +[ -e passfail ] || exit 44 PF2=$(cat passfail) -if [ "$PF1" != "$PF2" ]; then - echo "passfail changed even though it failed" >&2 - exit 42 -fi +[ "$PF1" = "$PF2" ] || exit 45 rm -f pleasefail -redo passfail || exit 43 +redo passfail || exit 46 PF3=$(cat passfail) -if [ "$PF1" = "$PF3" ]; then - echo "passfail did not change even though it passed" >&2 - exit 42 -fi +[ "$PF1" != "$PF3" ] || exit 47