diff --git a/builder.py b/builder.py index b8c898b..2e3c8c3 100644 --- a/builder.py +++ b/builder.py @@ -270,12 +270,13 @@ def main(targets, shouldbuildfunc): if rv: retcode[0] = 1 - for i in range(len(targets)): - t = targets[i] - # In the first cycle, we just build as much as we can without worrying # about any lock contention. If someone else has it locked, we move on. + seen = {} for t in targets: + if t in seen: + continue + seen[t] = 1 if not jwack.has_token(): state.commit() jwack.get_token(t) @@ -298,6 +299,8 @@ def main(targets, shouldbuildfunc): else: BuildJob(t, f, lock, shouldbuildfunc, done).start() + del lock + # Now we've built all the "easy" ones. Go back and just wait on the # remaining ones one by one. There's no reason to do it any more # efficiently, because if these targets were previously locked, that diff --git a/state.py b/state.py index 63dda35..458a2af 100644 --- a/state.py +++ b/state.py @@ -291,13 +291,17 @@ class File(object): # fcntl.lockf() instead. Usually this is just a wrapper for fcntl, so it's # ok, but it doesn't have F_GETLK, so we can't report which pid owns the lock. # The makes debugging a bit harder. When we someday port to C, we can do that. +_locks = {} class Lock: def __init__(self, fid): - assert(_lockfile >= 0) self.owned = False self.fid = fid + assert(_lockfile >= 0) + assert(_locks.get(fid,0) == 0) + _locks[fid] = 1 def __del__(self): + _locks[self.fid] = 0 if self.owned: self.unlock()