From 576e980c0e270f027fc7f8023301bd0a82cbc392 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Mon, 31 Dec 2018 19:35:56 -0500 Subject: [PATCH] t/351-deps-forget: remove a test that occasionally flakes. This is unfixable when running with -j > 1 because of how the current t/flush-cache script works. We'll only be able to fix that after making a more granular flush-cache tool, which is already on my todo list. --- t/351-deps-forget/all.do | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/351-deps-forget/all.do b/t/351-deps-forget/all.do index 49f6883..4b3e1f8 100644 --- a/t/351-deps-forget/all.do +++ b/t/351-deps-forget/all.do @@ -196,7 +196,17 @@ while read pre update post subran ran warn src targ ood XX; do if [ "$ood" = 1 ]; then is_ood || exit 35 else - ! is_ood || exit 36 + # FIXME: can't test this, as running ../flush-cache causes + # bork to always be out of date (since it is redo-always), + # and other parallel tests might run ../flush-cache + # at any time. + # + # We can fix this when we have a more granular flush-cache + # so that other tests can only flush their own targets, not + # ours. + # + # ! is_ood || exit 36 + : fi # FIXME: I'd like to not depend on the specific wording of warning