forks/apenwarr-redo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

shelltest.od: we accidentally treated some fails as mere warnings.

Browse source 
We were setting a global variable FAIL on failure, but if we failed
inside a subshell (which a very small number of tests might do), this
setting would be lost.  The script output (a series of failed/warning
lines) was still valid, but not the return code, so the shell might be
selected even if one of these tests failed.

To avoid the problem, put the fail/warning state in the filesystem
instead, which is shared across subshells.
This commit is contained in:
Avery Pennarun 2018-12-17 12:33:17 +00:00
commit 6cf06f707a
5 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
t/clean.do
View file

@ -2,5 +2,6 @@
sed 's/\.do$//' |
xargs redo
rm -f broken shellfile *~ .*~ stress.log flush-cache
rm -f broken shellfile shelltest.warned shelltest.failed \
*~ .*~ stress.log flush-cache
rm -rf 'space home dir'