From 8aea96cc906e6124fc5091612b8e42f84565a867 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Mon, 15 Nov 2010 20:46:09 -0800 Subject: [PATCH] Oops, don't use the SHELL environment variable after all. Reading the docs for GNU make more closely, it seems they *don't* use the one from the environment, because the user's interactive shell preferences shouldn't affect how the Makefile runs. Good point. In a Makefile, you can define SHELL explicitly, and that works. But let's worry about that some other time. --- redo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/redo.py b/redo.py index 89afa85..f758b6b 100755 --- a/redo.py +++ b/redo.py @@ -97,7 +97,7 @@ def _build(t): tmpname = '%s.redo.tmp' % t unlink(tmpname) f = open(tmpname, 'w+') - argv = [os.environ.get('SHELL', 'sh'), '-e', + argv = ['sh', '-e', os.path.basename(dofile), os.path.basename(t), 'FIXME', os.path.basename(tmpname)] if vars.VERBOSE: