forks/apenwarr-redo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove special case for "dirname" -> "dirname/all"

Browse source 
It actually decreases readability of the .do files - by not making it
explicit when you're going into a subdir.

Plus it adds ambiguity: what if there's a dirname.do *and* a dirname/all?
We could resolve the ambiguity if we wanted, but that adds more code, while
taking out this special case makes *less* code and improves readability.
I think it's the right way to go.
This commit is contained in:
Avery Pennarun 2010-11-24 02:48:27 -08:00
commit 984ad747f8
13 changed files with 38 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

3
builder.py
View file

@ -176,9 +176,6 @@ def main(targets, shouldbuildfunc):
for i in range(len(targets)):
t = targets[i]
if os.path.exists('%s/all.do' % t):
# t is a directory, but it has a default target
targets[i] = '%s/all' % t
# In the first cycle, we just build as much as we can without worrying
# about any lock contention. If someone else has it locked, we move on.