forks/apenwarr-redo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

redoconf: better handling of required vs optional detectors.

Browse source 
CC.rc was the only "mandatory" detection, which was weird and
inconsistent.  Instead, make it optional like the others, and have it
set a HAVE_CC variable appropriately (and have CXX.rc work the same
way).  Then, add a default.required.rc.od that checks the HAVE_* for
any variable and aborts if it is not available.

This allows us to fix confusing behaviour in allconfig.do, which would
try every compiler on the system, but redo would print a (non-fatal)
error message (and prevent redo-stamp optimization) when CC.rc failed
for any non-working compilers.  Now CC.rc just politely reports that it
didn't find a compiler.  Then we change all.rc.od to make CC.rc
mandatory.

Reported-by: Nathaniel Filardo <nwfilardo@gmail.com>
This commit is contained in:
Avery Pennarun 2019-02-23 16:45:08 -05:00
commit bdb8d8a27d
10 changed files with 56 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
redoconf/rc/CXX.rc.od
View file

@ -23,6 +23,7 @@ for d in "$@"; do
# it to include -lstdc++, etc.
# A future .rc could override this again.
rc_replaceln LINK "$d"
rc_replaceln HAVE_CXX 1
rc_save
exit 0
fi
@ -32,4 +33,3 @@ echo "Warning: Can't find a working C++ compiler." >&2
rc_undo
rc_replaceln CXX ""
rc_save
exit 0