From f4535be0cdeea29e7abd421b2e43ea4f2f7229e4 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Thu, 9 Dec 2010 00:45:13 -0800 Subject: [PATCH] Fix a deadlock. We were holding a database open with a read lock while a child redo might need to open it with a write lock. --- state.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/state.py b/state.py index 86a7b0d..3f56248 100644 --- a/state.py +++ b/state.py @@ -180,7 +180,7 @@ class File(object): def deps(self): q = "select mode, source from Deps where target=?" - for mode,source_id in db().execute(q, [self.id]): + for mode,source_id in db().execute(q, [self.id]).fetchall(): assert(mode in ('c', 'm')) name = File(id=source_id).name yield mode,name