0d174f92c3
I feel a little dirty doing this, but the way the code was before, redo almost always picked bash as the shell. bash is way too overpowered and this led to bashisms in do scripts unnecessarily. The two failures in dash are things that I would really like to have, but they haven't materialized after 6 years, so I guess we should be realistic. To appropriately penalize bash for asking for trouble, I added a warning about [ 1 == 1 ] syntax being valid (as opposed to the POSIX correct [ 1 = 1 ]). This allows dash to be selected ahead of bash. I also moved 'sh' to the end of the list, because although it's the weakest shell on some systems, on other systems it's just bash. And I put zsh in front of bash, because fewer people have zsh and we want them to test zsh.
67 lines
1.7 KiB
Text
67 lines
1.7 KiB
Text
exec >&2
|
|
redo-ifchange t/shelltest.od
|
|
|
|
rm -rf $1.new $1/sh
|
|
mkdir $1.new
|
|
|
|
GOOD=
|
|
WARN=
|
|
|
|
# Note: list low-functionality, maximally POSIX-like shells before more
|
|
# powerful ones. We want weaker shells to take precedence, as long as they
|
|
# pass the tests, because weaker shells are more likely to point out when you
|
|
# use some non-portable feature.
|
|
for sh in dash /usr/xpg4/bin/sh ash posh mksh ksh ksh88 ksh93 pdksh \
|
|
zsh bash busybox sh; do
|
|
printf "%-30s" "Testing $sh..."
|
|
FOUND=`which $sh 2>/dev/null` || { echo "missing"; continue; }
|
|
|
|
# It's important for the file to actually be named 'sh'. Some
|
|
# shells (like bash and zsh) only go into POSIX-compatible mode if
|
|
# they have that name. If they're not in POSIX-compatible mode,
|
|
# they'll fail the test.
|
|
rm -f $1.new/sh
|
|
ln -s $FOUND $1.new/sh
|
|
|
|
set +e
|
|
( cd t && ../$1.new/sh shelltest.od >shelltest.tmp 2>&1 )
|
|
RV=$?
|
|
set -e
|
|
|
|
msgs=
|
|
crash=
|
|
while read line; do
|
|
#echo "line: '$line'" >&2
|
|
stripw=${line#warning: }
|
|
stripf=${line#failed: }
|
|
crash=$line
|
|
[ "$line" = "$stripw" ] || msgs="$msgs W$stripw"
|
|
[ "$line" = "$stripf" ] || msgs="$msgs F$stripf"
|
|
done <t/shelltest.tmp
|
|
rm -f t/shelltest.tmp
|
|
msgs=${msgs# }
|
|
crash=${crash##*:}
|
|
crash=${crash# }
|
|
|
|
case $RV in
|
|
40) echo "ok $msgs"; [ -n "$GOOD" ] || GOOD=$FOUND ;;
|
|
41) echo "failed $msgs" ;;
|
|
42) echo "warnings $msgs"; [ -n "$WARN" ] || WARN=$FOUND ;;
|
|
*) echo "crash $crash" ;;
|
|
esac
|
|
done
|
|
|
|
rm -rf $1 $1.new $3
|
|
|
|
if [ -n "$GOOD" ]; then
|
|
echo "Selected perfect shell: $GOOD"
|
|
mkdir $3
|
|
ln -s $GOOD $3/sh
|
|
elif [ -n "$WARN" ]; then
|
|
echo "Selected mostly good shell: $WARN"
|
|
mkdir $3
|
|
ln -s $WARN $3/sh
|
|
else
|
|
echo "No good shells found! Maybe install dash, bash, or zsh."
|
|
exit 13
|
|
fi
|